Jacob was a patriarch but his prayer did not save his sons except Joseph. Why? David was the psalmist but Solomon's name is not found among RIGHTEOUS people. Why? Samuel was a high priest but his sons were notorious?. Why?… If they couldn't save their own family members, then what was the use of being a prophet, patriarch, or high priest? So confused. (India)

These righteous men of old suffered grief and loss because some of their children did not follow God. Yet, when people are developed and matured through their suffering, they become compassionate, godly people. 

These faithful ones will be rewarded on earth to become the human representatives of Christ’s spiritual reign. God said, “I will restore your leaders as in days of old, your rulers as at the beginning,” Isaiah 1:26 (NIV). They will be princes over the whole earth. Psalm 45:16, “Instead of Your fathers (the righteous of old) shall be(come) Your sons, Whom You (Christ and the church) shall make princes in all the earth.” 

It will be Jesus and His church who will elevate these righteous ones to this high ruling position. Because, “All these were approved through their faith, but they did not receive what was promised (an earthly resurrection and paradise), since God had provided something better for us (a heavenly resurrection), so that they would not be made perfect without us.” Hebrews 11:39-40 (CSB).

Because these people have proven faithful, they will be qualified to instruct mankind in righteousness. Isaiah 2:3 (NIV), “‘He (God) will teach us about his ways so that we may walk in his paths.’ For instruction will go out of Zion (the spiritual Christ and his church) and the word of the LORD from Jerusalem (the faithful people of old).” 

Respecting your concern about salvation, salvation is based on Christ’s sacrifice – not on the merit of their parents. Thankfully, the opportunity to receive eternal salvation is not limited to this life alone. Jesus “brought life and immortality to light through the gospel.” (2 Timothy 1:10)  This is the heavenly reward. 

But the vast majority of mankind will be offered life during Christ’s reign. Then “the Spirit and the bride (the spiritual class, Christ and His bride) say, ‘Come!’ And let him who hears say, ‘Come!’ And let him who thirsts come. Whoever desires, let him take the water of life freely.” Revelation 22:17. This is the opportunity of salvation offered in the resurrection age. It is to “whoever desires.” Each needs to make up his own mind.  

God’s benevolent purpose is to have heaven and earth live in accord with his perfect righteous will. “…the purpose which He has cherished in His own mind of restoring the whole creation to find its one Head in Christ; yes, things in Heaven and things on earth, to find their one Head in Him.”  Ephesians 1:9, 10 (Weymouth)